netdev - Re: [iproute2-next] tipc: support 128bit node identity for peer removing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42a727d2-385c-5918-f721-370e94695d41@gmail.com>
Date:   Tue, 1 Sep 2020 20:02:22 -0600
From:   David Ahern <dsahern@...il.com>
To:     Hoang Huu Le <hoang.h.le@...tech.com.au>, jmaloy@...hat.com,
        maloy@...jonn.com, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [iproute2-next] tipc: support 128bit node identity for peer
 removing

On 8/26/20 8:30 PM, Hoang Huu Le wrote:
> From: Hoang Le <hoang.h.le@...tech.com.au>
> 
> Problem:
> In kernel upstream, we add the support to set node identity with
> 128bit. However, we are still using legacy format in command tipc
> peer removing. Then, we got a problem when trying to remove
> offline node i.e:
> 
> $ tipc node list
> Node Identity                    Hash     State
> d6babc1c1c6d                     1cbcd7ca down
> 
> $ tipc peer remove address d6babc1c1c6d
> invalid network address, syntax: Z.C.N
> error: No such device or address
> 
> Solution:
> We add the support to remove a specific node down with 128bit
> node identifier, as an alternative to legacy 32-bit node address.
> 
> Acked-by: Jon Maloy <jmaloy@...hat.com>
> Signed-off-by: Hoang Huu Le <hoang.h.le@...tech.com.au>
> ---
>  tipc/peer.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 52 insertions(+), 1 deletion(-)
> 

applied to iproute2-next. Thanks