netdev - Re: [PATCH bpf-next] xsk: fix use-after-free in failed shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a6ccaa3-3e14-4159-bdee-026923e59474@iogearbox.net>
Date:   Wed, 2 Sep 2020 23:43:14 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Magnus Karlsson <magnus.karlsson@...el.com>, bjorn.topel@...el.com,
        ast@...nel.org, netdev@...r.kernel.org, jonathan.lemon@...il.com
Cc:     bpf@...r.kernel.org
Subject: Re: [PATCH bpf-next] xsk: fix use-after-free in failed shared_umem
 bind

On 9/2/20 9:36 AM, Magnus Karlsson wrote:
> Fix use-after-free when a shared umem bind fails. The code incorrectly
> tried to free the allocated buffer pool both in the bind code and then
> later also when the socket was released. Fix this by setting the
> buffer pool pointer to NULL after the bind code has freed the pool, so
> that the socket release code will not try to free the pool. This is
> the same solution as the regular, non-shared umem code path has. This
> was missing from the shared umem path.
> 
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> Reported-by: syzbot+5334f62e4d22804e646a@...kaller.appspotmail.com
> Fixes: b5aea28dca13 ("xsk: Add shared umem support between queue ids")

Lgtm, applied, thanks!