netdev - Re: [PATCH net-next 1/5] sfc: add and use efx_tx_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200902.155513.2158302550582662254.davem@davemloft.net>
Date:   Wed, 02 Sep 2020 15:55:13 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ecree@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] sfc: add and use efx_tx_send_pending in
 tx.c

From: Edward Cree <ecree@...arflare.com>
Date: Wed, 2 Sep 2020 15:35:53 +0100

> +	tx_queue->xmit_more_available = true;

I don't understand why you're setting xmit_more_available
unconditionally to true now instead of setting it to 'xmit_more' as
seen by this transmit attempt.  Why would you want to signal
that xmit_more handling might be necessary when you haven't been
given an xmit_more tx request?

If this change is in fact correct, it's something you need to explain
in the commit message.