[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200902.160831.2194160080454145229.davem@davemloft.net>
Date: Wed, 02 Sep 2020 16:08:31 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: awogbemila@...gle.com
Cc: kuba@...nel.org, netdev@...r.kernel.org, csully@...gle.com,
yangchun@...gle.com
Subject: Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register
From: David Awogbemila <awogbemila@...gle.com>
Date: Wed, 2 Sep 2020 11:42:37 -0700
> I don't think there is a specific 24-bit device in mind here, only
> that we have seen 32-bit addressing use cases where the guest ran out
> of SWIOTLB space and restricting to GFP_DMA32 helped.. so we thought
> it would be natural for the driver to handle the 24 bit case in case
> it ever came along.
You should add such support when the situation presents itself, rather
than prematurely like this.
Thank you.
Powered by blists - more mailing lists