netdev - Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zh68afdb.fsf@kurt>
Date:   Wed, 02 Sep 2020 07:59:12 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     David Miller <davem@...emloft.net>, richardcochran@...il.com
Cc:     andrew@...n.ch, olteanv@...il.com, vivien.didelot@...il.com,
        f.fainelli@...il.com, kuba@...nel.org, netdev@...r.kernel.org,
        robh+dt@...nel.org, devicetree@...r.kernel.org,
        bigeasy@...utronix.de, kamil.alkhouri@...offenburg.de,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH v4 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

On Tue Sep 01 2020, David Miller wrote:
> From: Richard Cochran <richardcochran@...il.com>
> Date: Tue, 1 Sep 2020 09:36:10 -0700
>
>> On Tue, Sep 01, 2020 at 05:59:45PM +0200, Andrew Lunn wrote:
>>> Maybe, at the moment, RTNL is keeping things atomic. But that is
>>> because there is no HWMON, or MDIO bus. Those sort of operations don't
>>> take the RTNL, and so would be an issue. I've also never audited the
>>> network stack to check RTNL really is held at all the network stack
>>> entry points to a DSA driver. It would be an interesting excesses to
>>> scatter some ASSERT_RTNL() in a DSA driver and see what happens.
>> 
>> Device drivers really aught to protect their state and their devices'
>> state from concurrent access.
>
> Completely agreed.

OK. So I'll keep the locking as is.

Since I have to have to prepare another version due to the compiler
warnings, I'll wait a bit for more comments and send the next version
after.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)