netdev - Re: [PATCH ethtool] ethtool: add support show/set-hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANn89i+3SGKw8CruFrQx2LZXOW2SNphSZHxStFsCJxY2Z+ZtxA@mail.gmail.com>
Date:   Wed, 2 Sep 2020 08:41:38 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kevin Yang <yyd@...gle.com>
Cc:     Andrew Lunn <andrew@...n.ch>, Michal Kubecek <mkubecek@...e.cz>,
        Networking <netdev@...r.kernel.org>,
        Neal Cardwell <ncardwell@...gle.com>
Subject: Re: [PATCH ethtool] ethtool: add support show/set-hwtstamp

On Wed, Sep 2, 2020 at 2:36 AM Kevin Yang <yyd@...gle.com> wrote:
>
> Hi Andrew,
>
> They are pretty much the same, both use ioctl(SIOCSHWTSTAMP).
>
> Adding this to ethtool is because:
> - This time stamping policy is a hardware setting aligned with ethtool's purpose "query and control network device driver and hardware settings"
> - ethtool is widely used, system administrators don't need to install another binary to control this feature.
>


Absolutely. ethtool has -T support already, and is the facto tool for
things not covered by iproute2 suite.

Having to remember a myriad of binaries that basically use a single
ioctl() is time consuming.

> Kevin
>
> On Tue, Sep 1, 2020 at 6:02 PM Andrew Lunn <andrew@...n.ch> wrote:
>>
>> On Tue, Sep 01, 2020 at 05:20:09PM -0400, Kevin(Yudong) Yang wrote:
>> > Before this patch, ethtool has -T/--show-time-stamping that only
>> > shows the device's time stamping capabilities but not the time
>> > stamping policy that is used by the device.
>>
>> Hi Kavin
>>
>> How does this differ from hwstamp_ctl(1)?
>>
>>     Andrew