netdev - Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d38ac31-8646-2c4f-616c-1a1341721819@ti.com>
Date:   Thu, 3 Sep 2020 11:41:15 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Florian Fainelli <f.fainelli@...il.com>, <davem@...emloft.net>,
        <andrew@...n.ch>, <hkallweit1@...il.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: phy: dp83867: Fix various styling and space
 issues

Florian

On 9/3/20 11:34 AM, Florian Fainelli wrote:
>
>
> On 9/3/2020 7:15 AM, Dan Murphy wrote:
>> Fix spacing issues reported for misaligned switch..case and extra new
>> lines.
>>
>> Also updated the file header to comply with networking commet style.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> ---
>>   drivers/net/phy/dp83867.c | 47 ++++++++++++++++++---------------------
>>   1 file changed, 22 insertions(+), 25 deletions(-)
>>
>> diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
>> index cd7032628a28..f182a8d767c6 100644
>> --- a/drivers/net/phy/dp83867.c
>> +++ b/drivers/net/phy/dp83867.c
>> @@ -1,6 +1,5 @@
>>   // SPDX-License-Identifier: GPL-2.0
>> -/*
>> - * Driver for the Texas Instruments DP83867 PHY
>> +/* Driver for the Texas Instruments DP83867 PHY
>>    *
>>    * Copyright (C) 2015 Texas Instruments Inc.
>>    */
>> @@ -35,7 +34,7 @@
>>   #define DP83867_CFG4_SGMII_ANEG_MASK (BIT(5) | BIT(6))
>>   #define DP83867_CFG4_SGMII_ANEG_TIMER_11MS   (3 << 5)
>>   #define DP83867_CFG4_SGMII_ANEG_TIMER_800US  (2 << 5)
>> -#define DP83867_CFG4_SGMII_ANEG_TIMER_2US    (1 << 5)
>> +#define DP83867_CFG4_SGMII_ANEG_TIMER_2US    BIT(5)
>
> Now the definitions are inconsistent, you would want to drop this one 
> and stick to the existing style.

OK I was a little conflicted making that change due to the reasons you 
mentioned.  But if that is an acceptable warning I am ok with it.


>
> The rest of the changes look good, so with that fixed, and the subject 
> correct to "net-next" (this is no bug fix material), you can add:
>
I will have to reapply this to the net-next to make sure it applies 
cleanly there.  But not an issue.

Dan


> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>