lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 03 Sep 2020 09:54:13 -0700 From: Joe Perches <joe@...ches.com> To: Dan Murphy <dmurphy@...com>, Florian Fainelli <f.fainelli@...il.com>, davem@...emloft.net, andrew@...n.ch, hkallweit1@...il.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] net: phy: dp83867: Fix various styling and space issues On Thu, 2020-09-03 at 11:41 -0500, Dan Murphy wrote: > On 9/3/20 11:34 AM, Florian Fainelli wrote: > > On 9/3/2020 7:15 AM, Dan Murphy wrote: > > > Fix spacing issues reported for misaligned switch..case and extra new > > > lines. [] > > > diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c [] > > > @@ -35,7 +34,7 @@ > > > #define DP83867_CFG4_SGMII_ANEG_MASK (BIT(5) | BIT(6)) > > > #define DP83867_CFG4_SGMII_ANEG_TIMER_11MS (3 << 5) > > > #define DP83867_CFG4_SGMII_ANEG_TIMER_800US (2 << 5) > > > -#define DP83867_CFG4_SGMII_ANEG_TIMER_2US (1 << 5) > > > +#define DP83867_CFG4_SGMII_ANEG_TIMER_2US BIT(5) > > Now the definitions are inconsistent, you would want to drop this one > > and stick to the existing style. > > OK I was a little conflicted making that change due to the reasons you > mentioned. But if that is an acceptable warning I am ok with it. Maybe use GENMASK for DP83867_CFG4_SGMII_ANEG_MASK instead.
Powered by blists - more mailing lists