netdev - Re: [PATCH net-next v2 4/9] gve: Add support for dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200903112846.5238ae0d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 3 Sep 2020 11:28:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Awogbemila <awogbemila@...gle.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Catherine Sullivan <csully@...gle.com>,
        Yangchun Fu <yangchun@...gle.com>
Subject: Re: [PATCH net-next v2 4/9] gve: Add support for dma_mask register

On Thu, 3 Sep 2020 09:31:16 -0700 David Awogbemila wrote:
> Thanks, I'll adjust this.

Please don't top post.

> On Wed, Sep 2, 2020 at 4:08 PM David Miller <davem@...emloft.net> wrote:
> >
> > From: David Awogbemila <awogbemila@...gle.com>
> > Date: Wed, 2 Sep 2020 11:42:37 -0700
> >  
> > > I don't think there is a specific 24-bit device in mind here, only
> > > that we have seen 32-bit addressing use cases where the guest ran out
> > > of SWIOTLB space and restricting to GFP_DMA32 helped.. so we thought
> > > it would be natural for the driver to handle the 24 bit case in case
> > > it ever came along.  

I see. That's clear enough, no need to CC anyone extra. Please just
make sure you make the motivation clear in your commit message.