netdev - Re: [PATCH net-next 2/2] ionic: add devlink firmware update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200903144559.4aae08f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 3 Sep 2020 14:45:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 2/2] ionic: add devlink firmware update

On Thu, 3 Sep 2020 14:37:40 -0700 Shannon Nelson wrote:
> On 9/3/20 12:53 PM, Jakub Kicinski wrote:
> > On Wed,  2 Sep 2020 12:57:17 -0700 Shannon Nelson wrote:  
> >> Add support for firmware update through the devlink interface.
> >> This update copies the firmware object into the device, asks
> >> the current firmware to install it, then asks the firmware to
> >> set the device to use the new firmware on the next boot-up.  
> > Activate sounds too much like fw-active in Moshe's patches.
> >
> > Just to be clear - you're not actually switching from the current
> > FW to the new one here, right?

Please answer this.

> > If it's more analogous to switching between flash images perhaps
> > selecting would be a better term?
> >  
> >> The install and activate steps are launched as asynchronous
> >> requests, which are then followed up with status requests
> >> commands.  These status request commands will be answered with
> >> an EAGAIN return value and will try again until the request
> >> has completed or reached the timeout specified.  
> 
> I think I can find a way to reword that - perhaps "enable" would be 
> better than "activate"?

I was saying "select". But "enable" is fine.