netdev - Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c01f9e0-fde4-a8ee-caa3-598738a9a98d@gmail.com>
Date:   Thu, 3 Sep 2020 09:24:50 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>, Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, linuxarm@...wei.com
Subject: Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and
 enqueue op for lockless qdisc



On 9/2/20 6:14 PM, Yunsheng Lin wrote:

> 
> It seems semantics for some_qdisc_is_busy() is changed, which does not only do
> the checking, but also do the reseting?

Yes, obviously, we would have to rename to a better name.

> 
> Also, qdisc_reset() could be called multi times for the same qdisc if some_qdisc_is_busy()
> return true multi times?

This should not matter, qdisc_reset() can be called multiple times,
as we also call it from qdisc_destroy() anyway.