netdev - Re: [PATCH] net/mlx5e: kTLS, Fix GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5F50E3D5.8090302@hisilicon.com>
Date:   Thu, 3 Sep 2020 20:38:45 +0800
From:   Wei Xu <xuwei5@...ilicon.com>
To:     <netdev@...r.kernel.org>
CC:     <davem@...emloft.net>, <saeedm@...lanox.com>, <leon@...nel.org>,
        <linuxarm@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
        <jonathan.cameron@...wei.com>, <john.garry@...wei.com>,
        <salil.mehta@...wei.com>, <shiju.jose@...wei.com>,
        <jinying@...ilicon.com>, <zhangyi.ac@...wei.com>,
        <liguozhu@...ilicon.com>, <tangkunshan@...wei.com>,
        <huangdaode@...ilicon.com>, Boris Pismenny <borisp@...dia.com>,
        "Saeed Mahameed" <saeedm@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        <linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5e: kTLS, Fix GFP_KERNEL in spinlock context

Hi All,

Sorry for the noise and please ignore it!
I found a nearly same patch has been sent out 2 days before.

Best Regards,
Wei

On 2020/9/3 19:45, Wei Xu wrote:
> Replace GFP_KERNEL with GFP_ATOMIC while resync_post_get_progress_params
> is invoked in a spinlock context.
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Wei Xu <xuwei5@...ilicon.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c
> index acf6d80..1a32435 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c
> @@ -247,7 +247,7 @@ resync_post_get_progress_params(struct mlx5e_icosq *sq,
>  	int err;
>  	u16 pi;
>  
> -	buf = kzalloc(sizeof(*buf), GFP_KERNEL);
> +	buf = kzalloc(sizeof(*buf), GFP_ATOMIC);
>  	if (unlikely(!buf)) {
>  		err = -ENOMEM;
>  		goto err_out;
>