netdev - Re: [PATCH] libbpf: Remove arch-specific include path in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c31ef991-25d0-dab4-819f-13eb38965a86@iogearbox.net>
Date:   Thu, 3 Sep 2020 15:51:14 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        bpf <bpf@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>,
        Networking <netdev@...r.kernel.org>,
        Vaidyanathan Srinivasan <svaidy@...ux.ibm.com>
Subject: Re: [PATCH] libbpf: Remove arch-specific include path in Makefile

On 9/3/20 7:46 AM, Naveen N. Rao wrote:
> Daniel Borkmann wrote:
>> On 9/2/20 10:58 PM, Andrii Nakryiko wrote:
>>> On Wed, Sep 2, 2020 at 1:43 AM Naveen N. Rao
>>> <naveen.n.rao@...ux.vnet.ibm.com> wrote:
>>>>
>>>> Ubuntu mainline builds for ppc64le are failing with the below error (*):
>>>>      CALL    /home/kernel/COD/linux/scripts/atomic/check-atomics.sh
>>>>      DESCEND  bpf/resolve_btfids
>>>>
>>>>    Auto-detecting system features:
>>>>    ...                        libelf: [ [32mon[m  ]
>>>>    ...                          zlib: [ [32mon[m  ]
>>>>    ...                           bpf: [ [31mOFF[m ]
>>>>
>>>>    BPF API too old
>>>>    make[6]: *** [Makefile:295: bpfdep] Error 1
>>>>    make[5]: *** [Makefile:54: /home/kernel/COD/linux/debian/build/build-generic/tools/bpf/resolve_btfids//libbpf.a] Error 2
>>>>    make[4]: *** [Makefile:71: bpf/resolve_btfids] Error 2
>>>>    make[3]: *** [/home/kernel/COD/linux/Makefile:1890: tools/bpf/resolve_btfids] Error 2
>>>>    make[2]: *** [/home/kernel/COD/linux/Makefile:335: __build_one_by_one] Error 2
>>>>    make[2]: Leaving directory '/home/kernel/COD/linux/debian/build/build-generic'
>>>>    make[1]: *** [Makefile:185: __sub-make] Error 2
>>>>    make[1]: Leaving directory '/home/kernel/COD/linux'
>>>>
>>>> resolve_btfids needs to be build as a host binary and it needs libbpf.
>>>> However, libbpf Makefile hardcodes an include path utilizing $(ARCH).
>>>> This results in mixing of cross-architecture headers resulting in a
>>>> build failure.
>>>>
>>>> The specific header include path doesn't seem necessary for a libbpf
>>>> build. Hence, remove the same.
>>>>
>>>> (*) https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.9-rc3/ppc64el/log
>>>>
>>>> Reported-by: Vaidyanathan Srinivasan <svaidy@...ux.ibm.com>
>>>> Signed-off-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
>>>> ---
>>>
>>> This seems to still build fine for me, so I seems fine. Not sure why
>>> that $(ARCH)/include/uapi path is there.
>>>
>>> Acked-by: Andrii Nakryiko <andriin@...com>
>>
>> Same here, builds fine from my side too. Looks like this was from the very early days,
>> added in commit 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature
>> check"). Applied, thanks!
> 
> Thanks!
> 
> Daniel, I see that this has been applied to bpf-next. Can you please consider sending this in for v5.9-rc series so as to resolve the build failures?

Ok, done, I've moved it to bpf tree so its on track for 5.9.

Thanks,
Daniel