netdev - Re: [PATCH net-next 0/6] l2tp: miscellaneous cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <655103fe-6881-1122-bbcb-62c59af2b102@katalix.com>
Date:   Thu, 3 Sep 2020 14:39:30 +0100
From:   James Chapman <jchapman@...alix.com>
To:     Tom Parkin <tparkin@...alix.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/6] l2tp: miscellaneous cleanups

On 03/09/2020 09:54, Tom Parkin wrote:
> This series of patches makes the following cleanups and improvements to
> the l2tp code:
>  
>  * various API tweaks to remove unused parameters from function calls
>  * lightly refactor the l2tp transmission path to capture more error
>    conditions in the data plane statistics
>  * repurpose the "magic feather" validation in l2tp to check for
>    sk_user_data (ab)use as opposed to refcount debugging
>  * remove some duplicated code
>
> Tom Parkin (6):
>   l2tp: remove header length param from l2tp_xmit_skb
>   l2tp: drop data_len argument from l2tp_xmit_core
>   l2tp: drop net argument from l2tp_tunnel_create
>   l2tp: capture more tx errors in data plane stats
>   l2tp: make magic feather checks more useful
>   l2tp: avoid duplicated code in l2tp_tunnel_closeall
>
>  net/l2tp/l2tp_core.c    | 134 +++++++++++++++++++---------------------
>  net/l2tp/l2tp_core.h    |  10 ++-
>  net/l2tp/l2tp_eth.c     |   2 +-
>  net/l2tp/l2tp_ip.c      |   2 +-
>  net/l2tp/l2tp_ip6.c     |   2 +-
>  net/l2tp/l2tp_netlink.c |   2 +-
>  net/l2tp/l2tp_ppp.c     |  15 ++++-
>  7 files changed, 87 insertions(+), 80 deletions(-)
>
Reviewed-by: James Chapman <jchapman@...alix.com>