netdev - Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200904155453.GB28910@plvision.eu>
Date:   Fri, 4 Sep 2020 18:54:53 +0300
From:   Vadym Kochan <vadym.kochan@...ision.eu>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        Serhiy Boiko <serhiy.boiko@...ision.eu>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Andrii Savka <andrii.savka@...ision.eu>,
        Network Development <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Mickey Rachamim <mickeyr@...vell.com>
Subject: Re: [PATCH net v6 1/6] net: marvell: prestera: Add driver for
 Prestera family ASIC devices

Hi Andrew,

On Fri, Sep 04, 2020 at 03:32:17PM +0200, Andrew Lunn wrote:
> > > > +static int prestera_is_valid_mac_addr(struct prestera_port *port, u8 *addr)
> > > > +{
> > > > +       if (!is_valid_ether_addr(addr))
> > > > +               return -EADDRNOTAVAIL;
> > > > +
> > > > +       if (memcmp(port->sw->base_mac, addr, ETH_ALEN - 1))
> > > 
> > > Why ETH_ALEN - 1?
> > > 
> > This is the restriction of the port mac address, it must have base mac
> > address part at first 5 bytes.
> 
> You probably want to put a comment here about that.
> 
> And this is particularly user unfriendly. Is this a hardware issue? Or
> firmware? Is this likely to change in the future?
> 
> 	  Andrew

It is required by the firmware, partially it may have relation to the
hardware.

I am not sure if it will be changed in the future. But I will add
a comment as you suggested.

Thanks,