netdev - RE: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR18MB32984DAF0FDED5D9CD1BEB45C62D0@BY5PR18MB3298.namprd18.prod.outlook.com>
Date:   Fri, 4 Sep 2020 16:36:29 +0000
From:   Sunil Kovvuri Goutham <sgoutham@...vell.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Srujana Challa <schalla@...vell.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Suheil Chandran <schandran@...vell.com>,
        Narayana Prasad Raju Athreya <pathreya@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        "Jerin Jacob Kollanukkaran" <jerinj@...vell.com>,
        Ard Biesheuvel <ardb@...nel.org>
Subject: RE: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
 OCTEONTX2 CPT engine



> -----Original Message-----
> From: Herbert Xu <herbert@...dor.apana.org.au>
> Sent: Friday, September 4, 2020 7:48 PM
> To: Srujana Challa <schalla@...vell.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-
> crypto@...r.kernel.org; Suheil Chandran <schandran@...vell.com>;
> Narayana Prasad Raju Athreya <pathreya@...vell.com>; Sunil Kovvuri
> Goutham <sgoutham@...vell.com>; Linu Cherian <lcherian@...vell.com>;
> Geethasowjanya Akula <gakula@...vell.com>; Jerin Jacob Kollanukkaran
> <jerinj@...vell.com>; Ard Biesheuvel <ardb@...nel.org>
> Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
> OCTEONTX2 CPT engine
> 
> On Fri, Sep 04, 2020 at 02:14:34PM +0000, Srujana Challa wrote:
> >
> > Since LMT store is our platform specific, it cannot be generalized to all
> ARM64.
> 
> I'm not asking you to generalise it to all of ARM64.  I'm asking you to move
> this into a header file under arch/arm64 that can then be shared by both your
> crypto driver and your network driver so you don't duplicate this
> everywhere.
> 

For ARM64 , except erratas other platform or machine dependent stuff are not allowed inside arch/arm64.
Also an earlier attempt by us to add few APIs addressing 128bit operations were not allowed by ARM folks
as they don't work in a generic way and are SOC specific.
http://lkml.iu.edu/hypermail/linux/kernel/1801.3/02211.html

Thanks,
Sunil.