lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Sep 2020 11:00:27 +0800 From: "wanghai (M)" <wanghai38@...wei.com> To: Willem de Bruijn <willemdebruijn.kernel@...il.com> CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, "John Ogness" <john.ogness@...utronix.de>, Mao Wenan <maowenan@...wei.com>, <jrosen@...co.com>, Arnd Bergmann <arnd@...db.de>, Colin King <colin.king@...onical.com>, Eric Dumazet <edumazet@...gle.com>, "Network Development" <netdev@...r.kernel.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV 在 2020/9/4 21:26, Willem de Bruijn 写道: > On Fri, Sep 4, 2020 at 3:09 PM Wang Hai <wanghai38@...wei.com> wrote: >> BPDU_TYPE_TCN is never used after it was introduced. >> So better to remove it. > This comment does not cover the patch contents. Otherwise the patch > looks good to me. Thanks for your review, I will revise this comment. >> Reported-by: Hulk Robot <hulkci@...wei.com> >> Signed-off-by: Wang Hai <wanghai38@...wei.com> >> --- >> net/packet/af_packet.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c >> index da8254e680f9..c430672c6a67 100644 >> --- a/net/packet/af_packet.c >> +++ b/net/packet/af_packet.c >> @@ -177,7 +177,6 @@ static int packet_set_ring(struct sock *sk, union tpacket_req_u *req_u, >> #define BLOCK_LEN(x) ((x)->hdr.bh1.blk_len) >> #define BLOCK_SNUM(x) ((x)->hdr.bh1.seq_num) >> #define BLOCK_O2PRIV(x) ((x)->offset_to_priv) >> -#define BLOCK_PRIV(x) ((void *)((char *)(x) + BLOCK_O2PRIV(x))) >> >> struct packet_sock; >> static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, >> -- >> 2.17.1 >> > . >
Powered by blists - more mailing lists