netdev - [PATCH net] net: macb: fix for pause frame receive enable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1599294093-30758-1-git-send-email-pthombar@cadence.com>
Date:   Sat, 5 Sep 2020 10:21:33 +0200
From:   Parshuram Thombare <pthombar@...ence.com>
To:     <nicolas.ferre@...rochip.com>, <alexandre.belloni@...tlin.com>
CC:     <claudiu.beznea@...rochip.com>, <antoine.tenart@...tlin.com>,
        <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <f.fainelli@...il.com>, <linux-kernel@...r.kernel.org>,
        <mparab@...ence.com>, Parshuram Thombare <pthombar@...ence.com>
Subject: [PATCH net] net: macb: fix for pause frame receive enable bit

PAE bit of NCFGR register, when set, pauses transmission
if a non-zero 802.3 classic pause frame is received.

Fixes: 7897b071ac3b ("net: macb: convert to phylink")
Signed-off-by: Parshuram Thombare <pthombar@...ence.com>
---
 drivers/net/ethernet/cadence/macb_main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 6761f40..9179f7b 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -647,8 +647,7 @@ static void macb_mac_link_up(struct phylink_config *config,
 				ctrl |= GEM_BIT(GBE);
 		}
 
-		/* We do not support MLO_PAUSE_RX yet */
-		if (tx_pause)
+		if (rx_pause)
 			ctrl |= MACB_BIT(PAE);
 
 		macb_set_tx_clk(bp->tx_clk, speed, ndev);
-- 
1.7.1