netdev - Re: [net-next PATCH] net: gemini: Try to register phy before netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200905155052.GI3164319@lunn.ch>
Date:   Sat, 5 Sep 2020 17:50:52 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>
Subject: Re: [net-next PATCH] net: gemini: Try to register phy before netdev

On Sat, Sep 05, 2020 at 12:45:30PM +0200, Linus Walleij wrote:
> It's nice if the phy is online before we register the netdev
> so try to do that first.

Hi Linus

The PHY handling in this driver is all a bit odd.

gmac_open() will also try to connect the PHY if it has not already
been found. gmac_stop() does not seem to have a symmetrical
phy_disconnect. However, gmac_uninit does?

I do wonder if more cleanup should be done while you are at it?

    Andrew