lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Sep 2020 18:56:45 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Linus Walleij <linus.walleij@...aro.org>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Russell King <linux@...linux.org.uk> Subject: Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink +Russell, On 9/5/2020 3:48 PM, Linus Walleij wrote: > This switches the RTL8366RB over to using phylink callbacks > instead of .adjust_link(). This is a pretty template > switchover. All we adjust is the CPU port so that is why > the code only inspects this port. > > We enhance by adding proper error messages, also disabling > the CPU port on the way down and moving dev_info() to > dev_dbg(). > > Signed-off-by: Linus Walleij <linus.walleij@...aro.org> The part of the former adjust_link, especially the part that forces the link to 1Gbit/sec, full duplex and no-autonegotiation probably belongs to a phylink_mac_config() implementation. Assuming that someone connects such a switch to a 10/100 Ethernet MAC and provides a fixed-link property in Device Tree, we should at least attempt to configure the CPU port interface based on those link settings, that is not happening today. -- Florian
Powered by blists - more mailing lists