netdev - Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200906094635.367ed5f8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 6 Sep 2020 09:46:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Parav Pandit <parav@...dia.com>
Cc:     Jiri Pirko <jiri@...nulli.us>, Parav Pandit <parav@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "roid@...lanox.com" <roid@...lanox.com>,
        "saeedm@...lanox.com" <saeedm@...lanox.com>,
        Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 2/3] devlink: Consider other controller while
 building phys_port_name

On Sun, 6 Sep 2020 03:08:45 +0000 Parav Pandit wrote:
> > >3) local:   { "controller ID": x }
> > >   remote1: { "controller ID": y, "external": true }
> > >   remote1: { "controller ID": z, "external": true }
> > >
> > >We don't have to put the controller ID in the name for local ports, but
> > >the attribute should be reported. AFAIU name was your main concern, no?  
> > 
> > Okay. Sounds fine. Let's put the controller number there for all ports.
> > ctrlnum X external true
> > ctrlnum Y external false
> > 
> > if (!external)
> > 	ignore the ctrlnum when generating the name
> >   
> 
> Putting little more realistic example for Jakub's and your suggestion below.
> 
> Below is the output for 3 controllers. ( 2 external + 1 local )
> Each external controller consist of 2 PCI PFs for a external host via single PCIe cable.
> Each local controller consist of 1 PCI PF.
> 
> $ devlink port show
> pci/0000:00:08.0/0: type eth netdev enp0s8f0_pf0 flavour pcipf pfnum 0 cnum 0 external false
> pci/0000:00:08.0/1: type eth netdev enp0s8f0_c1pf0 flavour pcipf pfnum 0 cnum 1 external true
> pci/0000:00:08.1/1: type eth netdev enp0s8f1_c1pf1 flavour pcipf pfnum 1 cnum 1 external true
> 
> Looks ok?

Yup, looks good, thanks.