netdev - Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200906105110.7e7fbfd4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 6 Sep 2020 10:51:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH] net: dsa: rtl8366rb: Switch to phylink

On Sun,  6 Sep 2020 00:48:28 +0200 Linus Walleij wrote:
> -static void rtl8366rb_adjust_link(struct dsa_switch *ds, int port,
> -				  struct phy_device *phydev)
> +void rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode,
> +			   phy_interface_t interface, struct phy_device *phydev,
> +			   int speed, int duplex, bool tx_pause, bool rx_pause)
>  {

> +void rtl8366rb_mac_link_down(struct dsa_switch *ds, int port, unsigned int mode,
> +			     phy_interface_t interface)
> +{	.get_sset_count = rtl8366_get_sset_count,


drivers/net/dsa/rtl8366rb.c:972:6: warning: no previous prototype for ‘rtl8366rb_mac_link_up’ [-Wmissing-prototypes]
  972 | void rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode,
      |      ^~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/rtl8366rb.c:1009:6: warning: no previous prototype for ‘rtl8366rb_mac_link_down’ [-Wmissing-prototypes]
 1009 | void rtl8366rb_mac_link_down(struct dsa_switch *ds, int port, unsigned int mode,
      |      ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/dsa/rtl8366rb.c:972:6: warning: symbol 'rtl8366rb_mac_link_up' was not declared. Should it be static?
drivers/net/dsa/rtl8366rb.c:1009:6: warning: symbol 'rtl8366rb_mac_link_down' was not declared. Should it be static?