netdev - Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200906123451.4ab26ee5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sun, 6 Sep 2020 12:34:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH] net: dsa: rtl8366: Properly clear member
 config

On Sun, 6 Sep 2020 21:23:37 +0200 Linus Walleij wrote:
> On Sun, Sep 6, 2020 at 7:41 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Sat,  5 Sep 2020 12:32:33 +0200 Linus Walleij wrote:  
> > > When removing a port from a VLAN we are just erasing the
> > > member config for the VLAN, which is wrong: other ports
> > > can be using it.
> > >
> > > Just mask off the port and only zero out the rest of the
> > > member config once ports using of the VLAN are removed
> > > from it.
> > >
> > > Reported-by: Florian Fainelli <f.fainelli@...il.com>
> > > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>  
> >
> > I see you labeled this for net-net, but it reads like a fix, is it not?
> >
> > Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> >
> > Like commit 15ab7906cc92 ("net: dsa: rtl8366: Fix VLAN semantics") had?  
> 
> Yes you're right, also it is pretty separate from the other patches to
> this driver so there shouldn't be any annoying conflicts.
> 
> If you're applying the patch could you add it
> in the process, or do you want me to resend?

Done & applied to net, thank you!