netdev - Re: [PATCH AUTOSEL 4.14 17/33] net: usb: qmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200907181552.GN8670@sasha-vm>
Date:   Mon, 7 Sep 2020 14:15:52 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Kristian Evensen <kristian.evensen@...il.com>
Cc:     linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>,
        Daniele Palmas <dnlplm@...il.com>,
        Bjørn Mork <bjorn@...k.no>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Network Development <netdev@...r.kernel.org>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 17/33] net: usb: qmi_wwan: add Telit 0x1050
 composition

On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote:
>Hi,
>
>On Sat, Oct 26, 2019 at 3:27 PM Sasha Levin <sashal@...nel.org> wrote:
>>
>> From: Daniele Palmas <dnlplm@...il.com>
>>
>> [ Upstream commit e0ae2c578d3909e60e9448207f5d83f785f1129f ]
>>
>> This patch adds support for Telit FN980 0x1050 composition
>>
>> 0x1050: tty, adb, rmnet, tty, tty, tty, tty
>>
>> Signed-off-by: Daniele Palmas <dnlplm@...il.com>
>> Acked-by: Bjørn Mork <bjorn@...k.no>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  drivers/net/usb/qmi_wwan.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>> index e406a05e79dcd..57e9166b4bff3 100644
>> --- a/drivers/net/usb/qmi_wwan.c
>> +++ b/drivers/net/usb/qmi_wwan.c
>> @@ -1252,6 +1252,7 @@ static const struct usb_device_id products[] = {
>>         {QMI_FIXED_INTF(0x2357, 0x0201, 4)},    /* TP-LINK HSUPA Modem MA180 */
>>         {QMI_FIXED_INTF(0x2357, 0x9000, 4)},    /* TP-LINK MA260 */
>>         {QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */
>> +       {QMI_QUIRK_SET_DTR(0x1bc7, 0x1050, 2)}, /* Telit FN980 */
>>         {QMI_FIXED_INTF(0x1bc7, 0x1100, 3)},    /* Telit ME910 */
>>         {QMI_FIXED_INTF(0x1bc7, 0x1101, 3)},    /* Telit ME910 dual modem */
>>         {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)},    /* Telit LE920 */
>> --
>> 2.20.1
>>
>
>When testing the FN980 with kernel 4.14, I noticed that the qmi device
>was not there. Checking the git log, I see that this patch was never
>applied. The patch applies fine, so I guess it was just missed
>somewhere. If it could be added to the next 4.14 release, it would be
>much appreciated.

Interesting, yes - I'm not sure why it's missing. I'll queue it up.

-- 
Thanks,
Sasha