netdev - Re: [PATCH net-next 2/6] sfc: remove phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5809ba4c-e2be-b3ab-7122-dee2241310d0@solarflare.com>
Date:   Mon, 7 Sep 2020 20:31:03 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/6] sfc: remove phy_op indirection

On 07/09/2020 20:22, Jakub Kicinski wrote:
> On Mon, 7 Sep 2020 17:14:34 +0100 Edward Cree wrote:
>>  drivers/net/ethernet/sfc/mcdi_port.c        | 593 +-------------------
>>  drivers/net/ethernet/sfc/mcdi_port_common.c | 560 ++++++++++++++++++
> Would you mind improving variable ordering and addressing checkpatch
> complaints while moving this code? The camel case and breaking up
> case statements warning can definitely be ignored, but there are others.
I'd prefer to do it as a separate follow-up patch, so that git tools
 can more reliably trace the history across the movement, per [1].
If the series needs respinning then I'll add it in v2, otherwise I'll
 post it standalone after this goes in.

-ed

[1]: https://yarchive.net/comp/linux/coding_style.html#16