netdev - Re: [PATCH] mwifiex: wmm: Fix -Wunused-const-variable warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0101017467b259ad-76b3249a-44bd-4d07-b4e5-2b809c85197a-000000@us-west-2.amazonses.com>
Date:   Mon, 7 Sep 2020 08:32:55 +0000
From:   Kalle Valo <kvalo@...eaurora.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <amitkarwar@...il.com>, <ganapathi.bhat@....com>,
        <huxinming820@...il.com>, <davem@...emloft.net>, <kuba@...nel.org>,
        <yuehaibing@...wei.com>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mwifiex: wmm: Fix -Wunused-const-variable warnings

YueHaibing <yuehaibing@...wei.com> wrote:

> In file included from drivers/net/wireless/marvell/mwifiex//cmdevt.c:26:0:
> drivers/net/wireless/marvell/mwifiex//wmm.h:41:17: warning: ‘tos_to_tid_inv’ defined but not used [-Wunused-const-variable=]
>  static const u8 tos_to_tid_inv[] = {
>                  ^~~~~~~~~~~~~~
> drivers/net/wireless/marvell/mwifiex//wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=]
>  static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 };
>                   ^~~~~~~~~~~~~~~~~~~~~~~
> 
> move the variables definition to .c file, and leave declarations
> in the header file to fix these warnings.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Patch applied to wireless-drivers-next.git, thanks.

d56ee19a148e mwifiex: wmm: Fix -Wunused-const-variable warnings

-- 
https://patchwork.kernel.org/patch/11750655/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches