netdev - Re: [RFC PATCH net-next 14/22] nexthop: Emit a notification when a nexthop group is modified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40a90c91-de9f-4512-329b-f91ac1bfe235@gmail.com>
Date:   Tue, 8 Sep 2020 09:29:52 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, roopa@...dia.com,
        mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH net-next 14/22] nexthop: Emit a notification when a
 nexthop group is modified

On 9/8/20 3:10 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> When a single nexthop is replaced, the configuration of all the groups
> using the nexthop is effectively modified. In this case, emit a
> notification in the nexthop notification chain for each modified group
> so that listeners would not need to keep track of which nexthops are
> member in which groups.
> 
> The notification can only be emitted after the new configuration (i.e.,
> 'struct nh_info') is pointed at by the old shell (i.e., 'struct
> nexthop'). Before that the configuration of the nexthop groups is still
> the same as before the replacement.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 32 ++++++++++++++++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...il.com>