lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Sep 2020 08:42:08 -0600
From:   David Ahern <>
To:     Jiri Pirko <>, Ido Schimmel <>
        Ido Schimmel <>
Subject: Re: [RFC PATCH net-next 03/22] nexthop: Only emit a notification when
 nexthop is actually deleted

On 9/8/20 8:39 AM, Jiri Pirko wrote:
> Tue, Sep 08, 2020 at 11:10:18AM CEST, wrote:
>> From: Ido Schimmel <>
>> Currently, the delete notification is emitted from the error path of
>> nexthop_add() and replace_nexthop(), which can be confusing to listeners
>> as they are not familiar with the nexthop.
>> Instead, only emit the notification when the nexthop is actually
>> deleted. The following sub-cases are covered:
> Well, in theory, this might break some very odd app that is adding a
> route and checking the errors using this notification. My opinion is to
> allow this breakage to happen, but I'm usually too benevolent :)

That would be a very twisted app.

No other notifications go out on failure to add / replace and nexthops
should be consistent.

Powered by blists - more mailing lists