netdev - Re: [RFC PATCH net-next 06/22] nexthop: Pass extack to nexthop notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80a556da-f68f-7c6a-8029-30fd9c6aa63a@gmail.com>
Date:   Tue, 8 Sep 2020 08:44:00 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, roopa@...dia.com,
        mlxsw@...dia.com, Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH net-next 06/22] nexthop: Pass extack to nexthop
 notifier

On 9/8/20 3:10 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...dia.com>
> 
> The next patch will add extack to the notification info. This allows
> listeners to veto notifications and communicate the reason to user space.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  net/ipv4/nexthop.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index 8c0f17c6863c..dafcb9f17250 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c
> @@ -38,7 +38,8 @@ static const struct nla_policy rtm_nh_policy[NHA_MAX + 1] = {
>  
>  static int call_nexthop_notifiers(struct net *net,
>  				  enum nexthop_event_type event_type,
> -				  struct nexthop *nh)
> +				  struct nexthop *nh,
> +				  struct netlink_ext_ack *extack)
>  {
>  	int err;
>  
> @@ -907,7 +908,7 @@ static void __remove_nexthop(struct net *net, struct nexthop *nh,
>  static void remove_nexthop(struct net *net, struct nexthop *nh,
>  			   struct nl_info *nlinfo)
>  {
> -	call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
> +	call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh, NULL);
>  
>  	/* remove from the tree */
>  	rb_erase(&nh->rb_node, &net->nexthop.rb_root);
> 

Reviewed-by: David Ahern <dsahern@...il.com>