netdev - RE: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for OCTEONTX2 CPT engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR18MB2791E9E6B435E27E8143836BA0290@BYAPR18MB2791.namprd18.prod.outlook.com>
Date:   Tue, 8 Sep 2020 14:20:52 +0000
From:   Srujana Challa <schalla@...vell.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "Suheil Chandran" <schandran@...vell.com>,
        Narayana Prasad Raju Athreya <pathreya@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        "Geethasowjanya Akula" <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Ard Biesheuvel <ardb@...nel.org>
Subject: RE: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
 OCTEONTX2 CPT engine

> Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
> OCTEONTX2 CPT engine
> 
> On Fri, Sep 04, 2020 at 04:36:29PM +0000, Sunil Kovvuri Goutham wrote:
> >
> >
> > > -----Original Message-----
> > > From: Herbert Xu <herbert@...dor.apana.org.au>
> > > Sent: Friday, September 4, 2020 7:48 PM
> > > To: Srujana Challa <schalla@...vell.com>
> > > Cc: davem@...emloft.net; netdev@...r.kernel.org; linux-
> > > crypto@...r.kernel.org; Suheil Chandran <schandran@...vell.com>;
> > > Narayana Prasad Raju Athreya <pathreya@...vell.com>; Sunil Kovvuri
> > > Goutham <sgoutham@...vell.com>; Linu Cherian <lcherian@...vell.com>;
> > > Geethasowjanya Akula <gakula@...vell.com>; Jerin Jacob Kollanukkaran
> > > <jerinj@...vell.com>; Ard Biesheuvel <ardb@...nel.org>
> > > Subject: Re: [EXT] Re: [PATCH v2 2/3] drivers: crypto: add support for
> > > OCTEONTX2 CPT engine
> > >
> > > On Fri, Sep 04, 2020 at 02:14:34PM +0000, Srujana Challa wrote:
> > > >
> > > > Since LMT store is our platform specific, it cannot be generalized to all
> > > ARM64.
> > >
> > > I'm not asking you to generalise it to all of ARM64.  I'm asking you to move
> > > this into a header file under arch/arm64 that can then be shared by both your
> > > crypto driver and your network driver so you don't duplicate this
> > > everywhere.
> > >
> >
> > For ARM64 , except erratas other platform or machine dependent stuff are not
> allowed inside arch/arm64.
> > Also an earlier attempt by us to add few APIs addressing 128bit operations were
> not allowed by ARM folks
> > as they don't work in a generic way and are SOC specific.
> > https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__lkml.iu.edu_hypermail_linux_kernel_1801.3_02211.html&d=DwIBAg&c=nKj
> Wec2b6R0mOyPaz7xtfQ&r=Fj4OoD5hcKFpANhTWdwQzjT1Jpf7veC5263T47JVpnc
> &m=_Crtymahn2yLpOWm4M2GAuzClE9EQVX2165DSnCx79E&s=FfyU3YaCxgJRXa
> 2EzyZrTvnWFYh8K2KmifpZAQN0gJk&e=
> 
> Maybe put it in include/linux/soc/ ?
>
 Okay, I will move this block of code into a header file under include/linux/soc.
Thanks.
 >       Andrew