netdev - Re: [PATCH net-next 6/6] sfc: simplify DMA mask setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200908151314.GA15543@infradead.org>
Date:   Tue, 8 Sep 2020 16:13:14 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     linux-net-drivers@...arflare.com, davem@...emloft.net,
        netdev@...r.kernel.org, Christoph Hellwig <hch@...radead.org>
Subject: Re: [PATCH net-next 6/6] sfc: simplify DMA mask setting

On Mon, Sep 07, 2020 at 05:15:48PM +0100, Edward Cree wrote:
> Christoph says[1] that dma_set_mask_and_coherent() is smart enough to
>  truncate the mask itself if it's too long.  So we can get rid of our
>  "lop off one bit and retry" loop in efx_init_io().
> 
> [1]: https://www.spinics.net/lists/netdev/msg677266.html
> 
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>