lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Sep 2020 09:34:39 +0100 From: Lee Jones <lee.jones@...aro.org> To: Kalle Valo <kvalo@...eaurora.org> Cc: davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Amitkumar Karwar <amitkarwar@...il.com>, Ganapathi Bhat <ganapathi.bhat@....com>, Xinming Hu <huxinming820@...il.com> Subject: Re: [24/30] mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused On Tue, 01 Sep 2020, Kalle Valo wrote: > Lee Jones <lee.jones@...aro.org> wrote: > > > 'mwifiex_1d_to_wmm_queue' is used in'; main.c, txrx.c and uap_txrx.c > > > > ... but not used in 14 other source files which include 'wmm.h'. > > > > Fixes the following W=1 kernel build warning(s): > > > > In file included from drivers/net/wireless/marvell/mwifiex/init.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/cmdevt.c:26: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/util.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/wmm.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/11n.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/11n_aggr.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/net/wireless/marvell/mwifiex/11n.h:25, > > from drivers/net/wireless/marvell/mwifiex/scan.c:25: > > drivers/net/wireless/marvell/mwifiex/wmm.h:34:18: warning: ‘mwifiex_1d_to_wmm_queue’ defined but not used [-Wunused-const-variable=] > > 34 | static const u16 mwifiex_1d_to_wmm_queue[8] = { 1, 0, 0, 1, 2, 2, 3, 3 }; > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > > > NB: Many entries - snipped for brevity. > > > > Cc: Amitkumar Karwar <amitkarwar@...il.com> > > Cc: Ganapathi Bhat <ganapathi.bhat@....com> > > Cc: Xinming Hu <huxinming820@...il.com> > > Cc: Kalle Valo <kvalo@...eaurora.org> > > Cc: "David S. Miller" <davem@...emloft.net> > > Cc: Jakub Kicinski <kuba@...nel.org> > > Cc: linux-wireless@...r.kernel.org > > Cc: netdev@...r.kernel.org > > Signed-off-by: Lee Jones <lee.jones@...aro.org> > > Failed to apply: > > fatal: sha1 information is lacking or useless (drivers/net/wireless/marvell/mwifiex/wmm.h). > error: could not build fake ancestor > Applying: mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused > Patch failed at 0001 mwifiex: wmm: Mark 'mwifiex_1d_to_wmm_queue' as __maybe_unused > The copy of the patch that failed is found in: .git/rebase-apply/patch > > Patch set to Changes Requested. I'll rebase everything I have onto -next and see about re-submitting. Thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists