netdev - Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 14:28:53 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Daniele Palmas <dnlplm@...il.com>
Cc:     Bjørn Mork <bjorn@...k.no>,
        Kristian Evensen <kristian.evensen@...il.com>,
        Paul Gildea <paul.gildea@...il.com>,
        Carl Yin <carl.yin@...ctel.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

On Wed, Sep 09, 2020 at 11:13:02AM +0200, Daniele Palmas wrote:
> Add default rx_urb_size to support QMAP download data aggregation
> without needing additional setup steps in userspace.
> 
> The value chosen is the current highest one seen in available modems.
> 
> The patch has the side-effect of fixing a babble issue in raw-ip mode
> reported by multiple users.
> 
> Signed-off-by: Daniele Palmas <dnlplm@...il.com>

Any specific kernel commit that this "fixes:"?

> ---
> Resending with mailing lists added: sorry for the noise.
> 
> Hi Bjørn and all,
> 
> this patch tries to address the issue reported in the following threads
> 
> https://www.spinics.net/lists/netdev/msg635944.html
> https://www.spinics.net/lists/linux-usb/msg198846.html
> https://www.spinics.net/lists/linux-usb/msg198025.html
> 
> so I'm adding the people involved, maybe you can give it a try to
> double check if this is good for you.
> 
> On my side, I performed tests with different QC chipsets without
> experiencing problems.
> 
> Thanks,
> Daniele
> ---
>  drivers/net/usb/qmi_wwan.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 07c42c0719f5..92d568f982b6 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -815,6 +815,10 @@ static int qmi_wwan_bind(struct usbnet *dev, struct usb_interface *intf)
>  	}
>  	dev->net->netdev_ops = &qmi_wwan_netdev_ops;
>  	dev->net->sysfs_groups[0] = &qmi_wwan_sysfs_attr_group;
> +
> +	/* Set rx_urb_size to allow QMAP rx data aggregation */
> +	dev->rx_urb_size = 32768;

Where did this "magic number" come from?

And making an urb size that big can keep some pipelines full, it also
comes at the expense of other potential issues, have you tested this to
see that it really does help in throughput?

And if it does, does this size really need to be that big?  What is it
set to today, the endpoint size?  If so, that's a huge jump...

thanks,

greg k-h