lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 9 Sep 2020 18:28:39 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Allen Pais <allen.lkml@...il.com>
Cc:     davem@...emloft.net, jes@...ined-monkey.org, kuba@...nel.org,
        dougmill@...ux.ibm.com, cooldavid@...ldavid.org,
        mlindner@...vell.com, stephen@...workplumber.org,
        borisp@...lanox.com, netdev@...r.kernel.org,
        Romain Perier <romain.perier@...il.com>
Subject: Re: [PATCH v2 16/20] ethernet: netronome: convert tasklets to use
 new tasklet_setup() API

On Wed, Sep 09, 2020 at 02:15:06PM +0530, Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
> 
> Signed-off-by: Romain Perier <romain.perier@...il.com>
> Signed-off-by: Allen Pais <allen.lkml@...il.com>

The correct prefix for NFP driver patches is "nfp: ", not
"ethernet: netronome: ". Possibly a similar comment applies to other
patches in this series.

Patches targeted at "net-next" should include "net-next" in the subject,
like this: [PATCH v2 net-next 16/20] ...

The patch itself seems fine to me.
So with the above fixed feel free to add:

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 21ea22694e47..b150da43adb2 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -2287,9 +2287,9 @@ static bool nfp_ctrl_rx(struct nfp_net_r_vector *r_vec)
>  	return budget;
>  }
>  
> -static void nfp_ctrl_poll(unsigned long arg)
> +static void nfp_ctrl_poll(struct tasklet_struct *t)
>  {
> -	struct nfp_net_r_vector *r_vec = (void *)arg;
> +	struct nfp_net_r_vector *r_vec = from_tasklet(r_vec, t, tasklet);
>  
>  	spin_lock(&r_vec->lock);
>  	nfp_net_tx_complete(r_vec->tx_ring, 0);
> @@ -2337,8 +2337,7 @@ static void nfp_net_vecs_init(struct nfp_net *nn)
>  
>  			__skb_queue_head_init(&r_vec->queue);
>  			spin_lock_init(&r_vec->lock);
> -			tasklet_init(&r_vec->tasklet, nfp_ctrl_poll,
> -				     (unsigned long)r_vec);
> +			tasklet_setup(&r_vec->tasklet, nfp_ctrl_poll);
>  			tasklet_disable(&r_vec->tasklet);
>  		}
>  
> -- 
> 2.25.1
> 

Powered by blists - more mailing lists