netdev - Re: [PATCH V3 net-next 4/4] net: ena: xdp: add queue counters for xdp actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200909085011.7af75de0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 9 Sep 2020 08:50:11 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     <sameehj@...zon.com>
Cc:     <davem@...emloft.net>, <netdev@...r.kernel.org>, <dwmw@...zon.com>,
        <zorik@...zon.com>, <matua@...zon.com>, <saeedb@...zon.com>,
        <msw@...zon.com>, <aliguori@...zon.com>, <nafea@...zon.com>,
        <gtzalik@...zon.com>, <netanel@...zon.com>, <alisaidi@...zon.com>,
        <benh@...zon.com>, <akiyano@...zon.com>, <ndagan@...zon.com>,
        Shay Agroskin <shayagr@...zon.com>
Subject: Re: [PATCH V3 net-next 4/4] net: ena: xdp: add queue counters for
 xdp actions

On Wed, 9 Sep 2020 06:46:27 +0000 sameehj@...zon.com wrote:
> @@ -374,17 +375,31 @@ static int ena_xdp_execute(struct ena_ring *rx_ring,
>  
>  	verdict = bpf_prog_run_xdp(xdp_prog, xdp);
>  
> -	if (verdict == XDP_TX)
> +	if (verdict == XDP_TX) {
>  		ena_xdp_xmit_buff(rx_ring->netdev,
> -				  xdp,
> -				  rx_ring->qid + rx_ring->adapter->num_io_queues,
> -				  rx_info);
> -	else if (unlikely(verdict == XDP_ABORTED))
> +				xdp,
> +				rx_ring->qid + rx_ring->adapter->num_io_queues,
> +				rx_info);

You broke the alignment here, for no reason.

Otherwise the series looks good.