netdev - Re: [PATCH net-next v3 7/7] net: mvpp2: ptp: add support for transmit timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 11:00:47 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Matteo Croce <mcroce@...hat.com>,
        Andre Przywara <andre.przywara@....com>,
        Sven Auhagen <sven.auhagen@...eatech.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 7/7] net: mvpp2: ptp: add support for
 transmit timestamping

On Tue, Sep 08, 2020 at 11:00:41PM +0100, Russell King wrote:

> +static bool mvpp2_tx_hw_tstamp(struct mvpp2_port *port,
> +			       struct mvpp2_tx_desc *tx_desc,
> +			       struct sk_buff *skb)
> +{
> +	unsigned int mtype, type, i, offset;
> +	struct mvpp2_hwtstamp_queue *queue;
> +	struct ptp_header *hdr;
> +	u64 ptpdesc;
> +
> +	if (port->priv->hw_version == MVPP21 ||
> +	    port->tx_hwtstamp_type == HWTSTAMP_TX_OFF)
> +		return false;
> +
> +	type = ptp_classify_raw(skb);
> +	if (!type)
> +		return false;
> +
> +	hdr = ptp_parse_header(skb, type);
> +	if (!hdr)
> +		return false;

At this point, the skb will be queued up to receive a transmit time
stamp, and so it should be marked with:

	skb_shinfo(skb)->tx_flags |= SKBTX_IN_PROGRESS;


The rest of the patch looks reasonable.

Acked-by: Richard Cochran <richardcochran@...il.com>