netdev - Re: [PATCH v2 07/20] ethernet: dlink: convert tasklets to use new tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 09 Sep 2020 11:11:16 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     allen.lkml@...il.com
Cc:     jes@...ined-monkey.org, kuba@...nel.org, dougmill@...ux.ibm.com,
        cooldavid@...ldavid.org, mlindner@...vell.com,
        stephen@...workplumber.org, borisp@...lanox.com,
        netdev@...r.kernel.org, romain.perier@...il.com
Subject: Re: [PATCH v2 07/20] ethernet: dlink: convert tasklets to use new
 tasklet_setup() API

From: Allen Pais <allen.lkml@...il.com>
Date: Wed,  9 Sep 2020 14:14:57 +0530

> @@ -1312,10 +1311,11 @@ static irqreturn_t intr_handler(int irq, void *dev_instance)
>  	return IRQ_RETVAL(handled);
>  }
>  
> -static void rx_poll(unsigned long data)
> +static void rx_poll(struct tasklet_struct *t)
>  {
> -	struct net_device *dev = (struct net_device *)data;
> -	struct netdev_private *np = netdev_priv(dev);
> +	struct netdev_private *np = from_tasklet(np, t, rx_tasklet);
> +	struct net_device *dev = (struct net_device *)((char *)np -
> +				  ALIGN(sizeof(struct net_device), NETDEV_ALIGN));

Just like patch #1, I don't want to see this brittle construct.