netdev - Re: [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 08 Sep 2020 20:09:39 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brianvv@...gle.com
Cc:     brianvv.kernel@...il.com, edumazet@...gle.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        svenjoac@....de, rdunlap@...radead.org
Subject: Re: [PATCH] fib: fix fib_rule_ops indirect call wrappers when
 CONFIG_IPV6=m

From: Brian Vazquez <brianvv@...gle.com>
Date: Tue,  8 Sep 2020 09:18:12 -0700

> If CONFIG_IPV6=m, the IPV6 functions won't be found by the linker:
> 
> ld: net/core/fib_rules.o: in function `fib_rules_lookup':
> fib_rules.c:(.text+0x606): undefined reference to `fib6_rule_match'
> ld: fib_rules.c:(.text+0x611): undefined reference to `fib6_rule_match'
> ld: fib_rules.c:(.text+0x68c): undefined reference to `fib6_rule_action'
> ld: fib_rules.c:(.text+0x693): undefined reference to `fib6_rule_action'
> ld: fib_rules.c:(.text+0x6aa): undefined reference to `fib6_rule_suppress'
> ld: fib_rules.c:(.text+0x6bc): undefined reference to `fib6_rule_suppress'
> make: *** [Makefile:1166: vmlinux] Error 1
> 
> Reported-by: Sven Joachim <svenjoac@....de>
> Fixes: b9aaec8f0be5 ("fib: use indirect call wrappers in the most common fib_rules_ops")
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
> Signed-off-by: Brian Vazquez <brianvv@...gle.com>

Applied, thanks.