netdev - Re: [PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Sep 2020 20:25:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yoshihiro.shimoda.uh@...esas.com
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        kuba@...nel.org, Jisheng.Zhang@...aptics.com,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2] net: phy: call phy_disable_interrupts() in
 phy_attach_direct() instead

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Date: Wed,  9 Sep 2020 08:55:38 +0900

>  Changes from v1:
>  - Fix build error.

When such a fundamental build failure is fixed (it could never have
built for anyone, even you), I want it explained why this happened
and how this was functionally tested if it did not even compile.

I'm not applying this patch, you must resubmit it again after
explaining what happened here instead of just quietly fixing
the build failure.

Thank you.