netdev - Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2929349-ca60-486d-3cad-a83321587c5f@microchip.com>
Date:   Thu, 10 Sep 2020 08:24:21 +0000
From:   <Nicolas.Ferre@...rochip.com>
To:     <joe@...ches.com>, <linux-kernel@...r.kernel.org>,
        <trivial@...nel.org>
CC:     <kees.cook@...onical.com>, <ndesaulniers@...gle.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <kvmarm@...ts.cs.columbia.edu>, <linux-mips@...r.kernel.org>,
        <linux-s390@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
        <linux-ide@...r.kernel.org>,
        <linux-atm-general@...ts.sourceforge.net>,
        <netdev@...r.kernel.org>, <intel-gfx@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>, <nouveau@...ts.freedesktop.org>,
        <linux-input@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        <linux-rdma@...r.kernel.org>, <iommu@...ts.linux-foundation.org>,
        <dm-devel@...hat.com>, <linux-media@...r.kernel.org>,
        <linux-mmc@...r.kernel.org>, <linux-mtd@...ts.infradead.org>,
        <intel-wired-lan@...ts.osuosl.org>, <oss-drivers@...ronome.com>,
        <linux-usb@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-nvme@...ts.infradead.org>, <linux-pm@...r.kernel.org>,
        <linux-rtc@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <storagedev@...rochip.com>, <sparclinux@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
        <linux-parisc@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
        <linux-afs@...ts.infradead.org>, <ceph-devel@...r.kernel.org>,
        <linux-nfs@...r.kernel.org>, <bpf@...r.kernel.org>,
        <dccp@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
        <coreteam@...filter.org>, <linux-sctp@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <Eugen.Hristev@...rochip.com>,
        <Ludovic.Desroches@...rochip.com>
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to
 break;

Joe,

Please drop this chunk: it's a successive controller version number 
which are all backward compatible with "fallthrough" on each case so 
removing from this last one makes it inconsistent.

In sort: NACK for atmel-mci.

Best regards,
   Nicolas


On 09/09/2020 at 22:06, Joe Perches wrote:
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 444bd3a0a922..8324312e4f42 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -2435,7 +2435,7 @@ static void atmci_get_cap(struct atmel_mci *host)
>          case 0x100:
>                  host->caps.has_bad_data_ordering = 0;
>                  host->caps.need_reset_after_xfer = 0;
> -               fallthrough;
> +               break;
>          case 0x0:
>                  break;
>          default:


-- 
Nicolas Ferre