lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 10 Sep 2020 12:16:33 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
        Jiri Kosina <trivial@...nel.org>
Cc:     linux-wireless@...r.kernel.org, linux-fbdev@...r.kernel.org,
        oss-drivers@...ronome.com, nouveau@...ts.freedesktop.org,
        alsa-devel <alsa-devel@...a-project.org>,
        dri-devel@...ts.freedesktop.org, linux-ide@...r.kernel.org,
        dm-devel@...hat.com, linux-mtd@...ts.infradead.org,
        linux-i2c@...r.kernel.org, sparclinux@...r.kernel.org,
        kvmarm@...ts.cs.columbia.edu, linux-rtc@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
        dccp@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-atm-general@...ts.sourceforge.net,
        linux-afs@...ts.infradead.org, coreteam@...filter.org,
        intel-wired-lan@...ts.osuosl.org, linux-serial@...r.kernel.org,
        linux-input@...r.kernel.org, linux-mmc@...r.kernel.org,
        Kees Cook <kees.cook@...onical.com>,
        linux-media@...r.kernel.org, linux-pm@...r.kernel.org,
        intel-gfx@...ts.freedesktop.org, linux-sctp@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-nvme@...ts.infradead.org,
        storagedev@...rochip.com, ceph-devel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-nfs@...r.kernel.org,
        linux-parisc@...r.kernel.org, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-mips@...r.kernel.org, iommu@...ts.linux-foundation.org,
        netfilter-devel@...r.kernel.org, linux-crypto@...r.kernel.org,
        bpf@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to
 break;



On 09/09/2020 22:06, Joe Perches wrote:
> diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
> index 09f931d4598c..778be26d329f 100644
> --- a/drivers/net/wireless/mediatek/mt7601u/dma.c
> +++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
> @@ -193,11 +193,11 @@ static void mt7601u_complete_rx(struct urb *urb)
>   	case -ESHUTDOWN:
>   	case -ENOENT:
>   		return;
> +	case 0:
> +		break;
>   	default:
>   		dev_err_ratelimited(dev->dev, "rx urb failed: %d\n",
>   				    urb->status);
> -		fallthrough;
> -	case 0:
>   		break;
>   	}
>   
> @@ -238,11 +238,11 @@ static void mt7601u_complete_tx(struct urb *urb)
>   	case -ESHUTDOWN:
>   	case -ENOENT:
>   		return;
> +	case 0:
> +		break;
>   	default:
>   		dev_err_ratelimited(dev->dev, "tx urb failed: %d\n",
>   				    urb->status);
> -		fallthrough;
> -	case 0:
>   		break;
>   	}

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

Powered by blists - more mailing lists