lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 10 Sep 2020 08:39:49 -0700
From:   Alexei Starovoitov <>
To:     Toke Høiland-Jørgensen <>
Cc:     David Ahern <>,
        Hangbin Liu <>, bpf <>,
        Network Development <>,
        Jiri Benc <>,
        Jesper Dangaard Brouer <>,
        Eelco Chaudron <>,
        Alexei Starovoitov <>,
        Daniel Borkmann <>,
        Lorenzo Bianconi <>,
        Andrii Nakryiko <>
Subject: Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map
 multicast support

On Thu, Sep 10, 2020 at 2:44 AM Toke Høiland-Jørgensen <> wrote:
> Alexei Starovoitov <> writes:
> > On Wed, Sep 9, 2020 at 8:30 PM David Ahern <> wrote:
> >> >
> >> > I think the packets modification (edit dst mac, add vlan tag, etc) should be
> >> > done on egress, which rely on David's XDP egress support.
> >>
> >> agreed. The DEVMAP used for redirect can have programs attached that
> >> update the packet headers - assuming you want to update them.
> >
> > Then you folks have to submit them as one set.
> > As-is the programmer cannot achieve correct behavior.
> The ability to attach a program to devmaps is already there. See:
> fbee97feed9b ("bpf: Add support to attach bpf program to a devmap entry")

ahh. you meant that one.

> But now that you mention it, it does appear that this series is skipping
> the hook that will actually run such a program. Didn't realise that was
> in the caller of bq_enqueue() and not inside bq_enqueue() itself...
> Hangbin, you'll need to add the hook for dev_map_run_prog() before
> bq_enqueue(); see the existing dev_map_enqueue() function.

If that's the expected usage it should have been described in the commit log
and thoroughly exercised in the tests.

Powered by blists - more mailing lists