netdev - RE: [PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Sep 2020 23:50:33 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     David Miller <davem@...emloft.net>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "Jisheng.Zhang@...aptics.com" <Jisheng.Zhang@...aptics.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v2] net: phy: call phy_disable_interrupts() in
 phy_attach_direct() instead

Hi Andrew,

> From: Andrew Lunn, Sent: Wednesday, September 9, 2020 10:47 PM
> 
> On Wed, Sep 09, 2020 at 04:18:56AM +0000, Yoshihiro Shimoda wrote:
> > Hi David,
> >
> > > From: David Miller, Sent: Wednesday, September 9, 2020 12:25 PM
> > >
> > > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > > Date: Wed,  9 Sep 2020 08:55:38 +0900
> > >
> > > >  Changes from v1:
> > > >  - Fix build error.
> > >
> > > When such a fundamental build failure is fixed (it could never have
> > > built for anyone, even you), I want it explained why this happened
> > > and how this was functionally tested if it did not even compile.
> >
> > I'm sorry about this. I used two PCs now:
> >  PC 1 = for testing at local
> >  PC 2 = for submitting patches at remote (because corporate network situation)
> >
> > I tested on the PC 1.
> > But, after that, I modified the code on the PC 2 again. And, it seemed
> > I didn't do a compile.
> 
> This sort of split setup is always a bad idea. Always do the git
> format-patch on PC 1 and somehow get the patch files off it, and use
> PC 2 only for git send-email, never any development work. That way you
> will avoid issues like this.

Thank you for your comment! I agree with you. I'll use such setup.

Best regards,
Yoshihiro Shimoda