netdev - Re: VLAN filtering with DSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55f93f28-76a2-90ad-8bee-3d45693a9018@gmail.com>
Date:   Thu, 10 Sep 2020 12:09:19 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: VLAN filtering with DSA



On 9/10/2020 12:08 PM, Vladimir Oltean wrote:
> On Thu, Sep 10, 2020 at 12:05:17PM -0700, Florian Fainelli wrote:
>> On 9/10/2020 12:01 PM, Vladimir Oltean wrote:
>>> On Thu, Sep 10, 2020 at 11:42:02AM -0700, Florian Fainelli wrote:
>>>> On 9/10/2020 8:07 AM, Vladimir Oltean wrote:
>>>> Yes, doing what you suggest would make perfect sense for a DSA master that
>>>> is capable of VLAN filtering, I did encounter that problem with e1000 and
>>>> the dsa-loop.c mockup driver while working on a mock-up 802.1Q data path.
>>>
>>> Yes, I have another patch where I add those VLANs from tag_8021q.c which
>>> I did not show here.
>>>
>>> But if the DSA switch that uses tag_8021q is cascaded to another one,
>>> that's of little use if the upper switch does not propagate that
>>> configuration to its own upstream.
>>
>> Yes, that would not work. As soon as you have a bridge spanning any of those
>> switches, does not the problem go away by virtue of the switch port forcing
>> the DSA master/upstream to be in promiscuous mode?
> 
> Well, yes, bridged it works but standalone it doesn't. A bit strange if
> you ask me.

Agreed there is no question this should be fixed.
-- 
Florian