netdev - Re: [PATCH ethtool] tunnels: implement new --show-tunnels command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200910121058.2be67e06@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Sep 2020 12:10:58 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH ethtool] tunnels: implement new --show-tunnels command

On Thu, 10 Sep 2020 12:16:05 +0200 Michal Kubecek wrote:
> On Wed, Sep 09, 2020 at 03:18:11PM -0700, Jakub Kicinski wrote:
> > Add support for the new show-tunnels command. Support dump.
> > 
> >  # ethtool --show-tunnels \*
> > Tunnel information for eth0:
> >   UDP port table 0:
> >     Size: 4
> >     Types: vxlan
> >     No entries
> >   UDP port table 1:
> >     Size: 4
> >     Types: geneve, vxlan-gpe
> >     Entries (2):
> >         port 1230, vxlan-gpe
> >         port 6081, geneve
> > 
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> 
> The patch looks good except for one cosmetic issue below. But you will
> need to update the uapi header copies first to get the new constants.
> You can use the script at the end of this mail.

Thanks! I wasn't sure if you sync yourself, like iproute2 folks do.
Now I know :)