lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 10 Sep 2020 12:57:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yoshihiro.shimoda.uh@...esas.com
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        kuba@...nel.org, Jisheng.Zhang@...aptics.com,
        netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2 RESEND] net: phy: call phy_disable_interrupts() in
 phy_attach_direct() instead

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Date: Wed,  9 Sep 2020 14:43:14 +0900

> Since the micrel phy driver calls phy_init_hw() as a workaround,
> the commit 9886a4dbd2aa ("net: phy: call phy_disable_interrupts()
> in phy_init_hw()") disables the interrupt unexpectedly. So,
> call phy_disable_interrupts() in phy_attach_direct() instead.
> Otherwise, the phy cannot link up after the ethernet cable was
> disconnected.
> 
> Note that other drivers (like at803x.c) also calls phy_init_hw().
> So, perhaps, the driver caused a similar issue too.
> 
> Fixes: 9886a4dbd2aa ("net: phy: call phy_disable_interrupts() in phy_init_hw()")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> ---
>  Changes from v1:
>  - Fix build failure. I used two PCs: PC 1) for testing, PC 2) for
>    submitting patches. I tested on the PC 1. But, after that, I wrote
>    a patch on the PC2 again, and it seemed I didn't do a compile...
>    Today, I got some emails from kernel test bot. So, I realized
>    I had submitted an awful patch. To avoid such failure, I'll use
>    one PC only from now on.
> 

Applied and queued up for -stable, thanks.

Powered by blists - more mailing lists