netdev - Re: [PATCH 4/5] dpaa2-eth: utilize skb->cb[0] for hardware timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200910074204.2535d416@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Sep 2020 07:42:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yangbo Lu <yangbo.lu@....com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Ioana Radulescu <ruxandra.radulescu@....com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH 4/5] dpaa2-eth: utilize skb->cb[0] for hardware
 timestamping

On Thu, 10 Sep 2020 17:38:34 +0800 Yangbo Lu wrote:
> @@ -2107,7 +2111,7 @@ static int dpaa2_eth_xdp_create_fd(struct net_device *net_dev,
>  	/* We require a minimum headroom to be able to transmit the frame.
>  	 * Otherwise return an error and let the original net_device handle it
>  	 */
> -	needed_headroom = dpaa2_eth_needed_headroom(priv, NULL);
> +	needed_headroom = dpaa2_eth_needed_headroom(NULL);
>  	if (xdpf->headroom < needed_headroom)
>  		return -EINVAL;
>  
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function ‘dpaa2_eth_xdp_create_fd’:
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2104:25: warning: unused variable ‘priv’ [-Wunused-variable]
 2104 |  struct dpaa2_eth_priv *priv = netdev_priv(net_dev);
      |                         ^~~~