netdev - Re: [PATCH v2] net: Phy: Add PHY lookup support on MDIO bus in case of ACPI probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200910074454.7e4b0940@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Sep 2020 07:44:54 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vikas Singh <vikas.singh@...esoftware.com>
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        calvin.johnson@....nxp.com, kuldip.dwivedi@...esoftware.com,
        madalin.bucur@....nxp.com, vikas.singh@....com
Subject: Re: [PATCH v2] net: Phy: Add PHY lookup support on MDIO bus in case
 of ACPI probe

On Thu, 10 Sep 2020 17:13:03 +0530 Vikas Singh wrote:
> The function referred to (of_mdiobus_link_mdiodev()) is only built when
> CONFIG_OF_MDIO is enabled, which is again, a DT specific thing, and would
> not work in case of ACPI.
> Given that it is a static function so renamed of_mdiobus_link_mdiodev()
> as mdiobus_link_mdiodev() and did necessary changes, finally moved it out
> of the #ifdef(CONFIG_OF_MDIO) therefore make it work for both DT & ACPI.
> 
> Signed-off-by: Vikas Singh <vikas.singh@...esoftware.com>

nit:

CHECK: braces {} should be used on all arms of this statement
#60: FILE: drivers/net/phy/mdio_bus.c:461:
+		if (is_of_node(child)) {
[...]
+		} else if (fwnode_property_read_u32(child, "reg", &addr))
[...]