netdev - Re: [PATCH] net: mvpp2: ptp: Fix unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200910.151607.1755041538732050239.davem@davemloft.net>
Date:   Thu, 10 Sep 2020 15:16:07 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     alex.dewar90@...il.com
Cc:     kuba@...nel.org, rmk+kernel@...linux.org.uk, mcroce@...rosoft.com,
        sven.auhagen@...eatech.de, andrew@...n.ch, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mvpp2: ptp: Fix unused variables

From: Alex Dewar <alex.dewar90@...il.com>
Date: Thu, 10 Sep 2020 14:49:10 +0100

> In the functions mvpp2_isr_handle_xlg() and
> mvpp2_isr_handle_gmac_internal(), the bool variable link is assigned a
> true value in the case that a given bit of val is set. However, if the
> bit is unset, no value is assigned to link and it is then passed to
> mvpp2_isr_handle_link() without being initialised. Fix by assigning to
> link the value of the bit test.
> 
> Build-tested on x86.
> 
> Fixes: 36cfd3a6e52b ("net: mvpp2: restructure "link status" interrupt handling")
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>

Applied to net-next.