netdev - Re: [RFC PATCH net-next 09/22] rtnetlink: Add RTNH_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200911152601.GE3160975@shredder>
Date:   Fri, 11 Sep 2020 18:26:01 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        roopa@...dia.com, mlxsw@...dia.com,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [RFC PATCH net-next 09/22] rtnetlink: Add RTNH_F_TRAP flag

On Tue, Sep 08, 2020 at 09:02:33AM -0600, David Ahern wrote:
> On 9/8/20 3:10 AM, Ido Schimmel wrote:
> > From: Ido Schimmel <idosch@...dia.com>
> > 
> > The flag indicates to user space that the nexthop is not programmed to
> > forward packets in hardware, but rather to trap them.
> 
> please elaborate in the commit message on what 'trap' is doing. I most
> likely will forget a few years from now.

Reworded to:

"
rtnetlink: Add RTNH_F_TRAP flag

The flag indicates to user space that the nexthop is not programmed to
forward packets in hardware, but rather to trap them to the CPU. This is
needed, for example, when the MAC of the nexthop neighbour is not
resolved and packets should reach the CPU to trigger neighbour
resolution.

The flag will be used in subsequent patches by netdevsim to test nexthop
objects programming to device drivers and in the future by mlxsw as
well.

Signed-off-by: Ido Schimmel <idosch@...dia.com>
Reviewed-by: David Ahern <dsahern@...il.com>
"

> 
> > 
> > The flag will be used in subsequent patches by netdevsim to test nexthop
> > objects programming to device drivers and in the future by mlxsw as
> > well.
> > 
> > Signed-off-by: Ido Schimmel <idosch@...dia.com>
> > ---
> >  include/uapi/linux/rtnetlink.h | 6 ++++--
> >  net/ipv4/fib_semantics.c       | 2 ++
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > 
> 
> Reviewed-by: David Ahern <dsahern@...il.com>